HyukjinKwon opened a new pull request, #50846:
URL: https://github.com/apache/spark/pull/50846

   ### What changes were proposed in this pull request?
   
   This PR is a followup of https://github.com/apache/spark/pull/50575 that 
sets the initial Spark Connect mode by reading `SPARK_CONNECT_MODE`.
   
   ### Why are the changes needed?
   
   In Spark 4.0 release (Spark Connect distribution),
   
   ```bash
   SPARK_CONNECT_MODE=1 ./bin/spark-shell
   ```
   
   starts Spark Classic shells.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No to end users because the main change has not been released yet.
   
   ### How was this patch tested?
   
   Manually tested with some combinations below:
   
   ```
   SPARK_CONNECT_MODE=1 ./bin/spark-shell
   SPARK_CONNECT_MODE=1 ./bin/spark-shell --master local
   SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic --master 
local
   SPARK_CONNECT_MODE=1 ./bin/pyspark  --master local --conf 
spark.api.mode=connect
   SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=classic
   SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.api.mode=connect
   SPARK_CONNECT_MODE=1 ./bin/pyspark
   SPARK_CONNECT_MODE=0 ./bin/spark-shell
   SPARK_CONNECT_MODE=0 ./bin/spark-shell --master local
   SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic --master 
local
   SPARK_CONNECT_MODE=0 ./bin/pyspark  --master local --conf 
spark.api.mode=connect
   SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=classic
   SPARK_CONNECT_MODE=0 ./bin/pyspark --conf spark.api.mode=connect
   SPARK_CONNECT_MODE=0 ./bin/pyspark
   SPARK_CONNECT_MODE=1 ./bin/spark-shell --master "local[*]" --remote 
"local[*]"
   SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf 
spark.api.mode=connect --conf spark.master="local[*]"
   SPARK_CONNECT_MODE=1 ./bin/pyspark --master "local[*]" --remote "local[*]"
   SPARK_CONNECT_MODE=1 ./bin/pyspark --conf spark.remote="local[*]" --conf 
spark.api.mode=connect --master "local[*]"
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to