Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6660#discussion_r31794306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -309,6 +383,26 @@ case class If(predicate: Expression, trueValue:
Expression, falseValue: Expressi
falseValue.eval(input)
}
}
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
Code = {
+ val condEval = predicate.gen(ctx)
+ val trueEval = trueValue.gen(ctx)
+ val falseEval = falseValue.gen(ctx)
+
+ s"""
+ boolean ${ev.nullTerm} = false;
+ ${ctx.primitiveType(dataType)} ${ev.primitiveTerm} =
${ctx.defaultValue(dataType)};
+ ${condEval.code}
--- End diff --
should we move this to the front, so the declaration of ev.nullTerm is
closer to where it is set?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
