cloud-fan commented on code in PR #50937:
URL: https://github.com/apache/spark/pull/50937#discussion_r2101473291
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyDefaultCollationToStringType.scala:
##########
@@ -32,10 +33,12 @@ import org.apache.spark.sql.types.{DataType, StringType}
*/
object ApplyDefaultCollationToStringType extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = {
- fetchDefaultCollation(plan) match {
+ val planWithResolvedDefaultCollation = ResolveDefaultCollation(plan)
Review Comment:
why do we add a rule but invoke it as a function? can we just add a new
function in `ApplyDefaultCollationToStringType`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
