LuciferYang commented on code in PR #51013:
URL: https://github.com/apache/spark/pull/51013#discussion_r2106532759


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -414,9 +414,20 @@ case class WriteDelta(
 trait V2CreateTableAsSelectPlan
   extends V2CreateTablePlan
     with AnalysisOnlyCommand
-    with CTEInChildren {
+    with CTEInChildren
+    with ExecutableDuringAnalysis {

Review Comment:
   @yuexing Does this pull request (PR) only address the scenario for 
DataSource V2? Is there no such issue for V1? Or was the fix for V1 omitted?



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -414,9 +414,20 @@ case class WriteDelta(
 trait V2CreateTableAsSelectPlan
   extends V2CreateTablePlan
     with AnalysisOnlyCommand
-    with CTEInChildren {
+    with CTEInChildren
+    with ExecutableDuringAnalysis {

Review Comment:
   @yuexing Does this pull request  only address the scenario for DataSource 
V2? Is there no such issue for V1? Or was the fix for V1 omitted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to