dongjoon-hyun commented on code in PR #176:
URL:
https://github.com/apache/spark-connect-swift/pull/176#discussion_r2107963712
##########
Sources/SparkConnect/SparkConnectClient.swift:
##########
@@ -781,8 +781,17 @@ public actor SparkConnectClient {
ddlParse.ddlString = ddlString
return OneOf_Analyze.ddlParse(ddlParse)
})
- let response = try await service.analyzePlan(request)
- return response.ddlParse.parsed
+ do {
+ let response = try await service.analyzePlan(request)
+ return response.ddlParse.parsed
+ } catch let error as RPCError where error.code == .internalError {
+ switch error.message {
+ case let m where m.contains("UNSUPPORTED_DATATYPE") ||
m.contains("INVALID_IDENTIFIER"):
Review Comment:
Yes, I'm currently mapping the internal error to `SparkConnectError` by
finding the details.
I can make `INVALID_IDENTIFIER` to the official one of `SparkConnectError`
when I collect more instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
