Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6587#discussion_r31816074
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -68,7 +68,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] {
* generating case class `equals` methods
*/
def fastEquals(other: TreeNode[_]): Boolean = {
- this.eq(other) || this == other
+ this.eq(other)// || this == other
--- End diff --
I'm a little nervous about this change. Before it, we can create a same
tree node(not return the origin one) during tree node transformation which will
be regarded as no-change and finally make the batch reach fixed point. However,
we can't do this now and may make a batch exceed max iterations which will slow
down batch execution dramatically.
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
