Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6560#discussion_r31836619
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala
---
@@ -23,15 +23,16 @@ import java.util.Properties
import scala.collection.mutable
import scala.util.matching.Regex
-import org.apache.spark.Logging
import org.apache.spark.util.Utils
+import org.apache.spark.{Logging, SparkConf}
-private[spark] class MetricsConfig(val configFile: Option[String]) extends
Logging {
+private[spark] class MetricsConfig(conf: SparkConf) extends Logging {
private val DEFAULT_PREFIX = "*"
private val INSTANCE_REGEX = "^(\\*|[a-zA-Z]+)\\.(.+)".r
private val DEFAULT_METRICS_CONF_FILENAME = "metrics.properties"
+ private[metrics] val configFile = conf.getOption("spark.metrics.conf")
--- End diff --
probably doesn't need to be an instance variable since it's only used in 1
place
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
