vladimirg-db commented on code in PR #51128:
URL: https://github.com/apache/spark/pull/51128#discussion_r2138872268
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/NormalizePlan.scala:
##########
@@ -166,6 +166,42 @@ object NormalizePlan extends PredicateHelper {
innerProject.child
)
Project(normalizeProjectList(outerProjectList), newInnerProject)
+ case project @ Project(_, innerAggregate: Aggregate) =>
Review Comment:
This is actually a bottom-up traversal. The bottom-up approach is needed to
correctly compute `hashCode` based on normalized subtrees when sorting
predicates.
Still, let me thing how to make this pattern match nicer...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
