mihailom-db commented on code in PR #51179:
URL: https://github.com/apache/spark/pull/51179#discussion_r2149351480
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:
##########
@@ -2746,7 +2746,11 @@ object TryMakeTimestampLTZExpressionBuilder extends
ExpressionBuilder {
// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(year, month, day, hour, min, sec[, timezone]) - Create
timestamp from year, month, day, hour, min, sec and timezone fields. The result
data type is consistent with the value of configuration
`spark.sql.timestampType`. If the configuration `spark.sql.ansi.enabled` is
false, the function returns NULL on invalid inputs. Otherwise, it will throw an
error instead.",
+ usage = """
+ _FUNC_(year, month, day, hour, min, sec[, timezone]) - Create timestamp
from year, month, day, hour, min, sec and timezone fields. The result data type
is consistent with the value of configuration `spark.sql.timestampType`. If the
configuration `spark.sql.ansi.enabled` is false, the function returns NULL on
invalid inputs. Otherwise, it will throw an error instead.
Review Comment:
nit: Should we move the output type and error out comments after the second
declaration of the function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
