mihailom-db commented on code in PR #51090:
URL: https://github.com/apache/spark/pull/51090#discussion_r2153059313
##########
python/pyspark/pandas/correlation.py:
##########
@@ -219,6 +224,43 @@ def compute(sdf: SparkDataFrame, groupKeys: List[str],
method: str) -> SparkData
F.col(CORRELATION_VALUE_2_COLUMN) ==
F.col(CORRELATION_VALUE_Y_COLUMN)
)
+ spark_session = SparkSession.getActiveSession()
+ if is_ansi_mode_enabled(spark_session):
Review Comment:
True, but here in the code, you are running try_divide only if ANSI is ON,
and / when ANSI is OFF. When ANSI is OFF / returns NULL, same as try_divide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
