cloud-fan commented on code in PR #51182:
URL: https://github.com/apache/spark/pull/51182#discussion_r2153373392
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala:
##########
@@ -3686,6 +3687,96 @@ abstract class CSVSuite
parameters = Map("columnName" -> "`v`", "columnType" -> "\"VARIANT\"",
"format" -> "CSV")
)
}
+
+ private def createTestFiles(dir: File, fileFormatWriter: Boolean,
Review Comment:
shall we put the test in `FileBasedDataSourceSuite`, so that it's easier to
share code and test different formats?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
