Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/636#discussion_r12472994
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/ApplicationDescription.scala ---
    @@ -28,6 +28,7 @@ private[spark] class ApplicationDescription(
       extends Serializable {
     
       val user = System.getProperty("user.name", "<unknown>")
    -
    +  // only valid when spark.executor.multiPerWorker is set to true
    +  var maxCorePerExecutor = maxCores
    --- End diff --
    
    yes i know. but in ApplicationInfo.scala the coresLeft value is same to the 
value of  desc.maxCores. in schedule leftCoreToAssign actually is equto to 
maxCorePerExecutor. so i think there are not right because leftCoreToAssign  is 
total cores of all executors and maxCorePerExecutor is cores of one executor. i 
donot know whether you understand it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to