aokolnychyi commented on code in PR #51091:
URL: https://github.com/apache/spark/pull/51091#discussion_r2162712171
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/MergeRowsExec.scala:
##########
@@ -69,6 +71,14 @@ case class MergeRowsExec(
copy(child = newChild)
}
+ override lazy val metrics: Map[String, SQLMetric] = Map(
Review Comment:
Is there a pattern where Spark usually defines metrics? At least, we have to
group them with other variables above. I also see metrics are frequently the
first thing defined in an exec node. Let's be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
