mihailom-db commented on code in PR #51335:
URL: https://github.com/apache/spark/pull/51335#discussion_r2177531791
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1349,32 +1362,24 @@ type
| FLOAT | REAL
| DOUBLE
| DATE
- | TIME
- | TIMESTAMP | TIMESTAMP_NTZ | TIMESTAMP_LTZ
- | STRING collateClause?
- | CHARACTER | CHAR
- | VARCHAR
+ | TIMESTAMP_LTZ | TIMESTAMP_NTZ | TIMESTAMP (WITHOUT TIME ZONE)?
| BINARY
- | DECIMAL | DEC | NUMERIC
| VOID
| INTERVAL
| VARIANT
- | ARRAY | STRUCT | MAP
- | unsupportedType=identifier
+ ;
+
+primitiveType
+ : primitiveTypeWithParameters
+ | primitiveTypeWithoutParameters
+ | unsupportedType=identifier (LEFT_PAREN INTEGER_VALUE(COMMA
INTEGER_VALUE)* RIGHT_PAREN)?
Review Comment:
Yeah, this potentially can make a problem. I mean, we would probably return
a bad error message. Let me think if we can scope issues like this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
