szehon-ho commented on code in PR #51373: URL: https://github.com/apache/spark/pull/51373#discussion_r2184542253
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala: ########## @@ -120,9 +120,23 @@ trait ExternalCatalog { * @param db Database that table to alter schema for exists in * @param table Name of table to alter schema for * @param newDataSchema Updated data schema to be used for the table. + * @deprecated since 4.1.0 use `alterTableSchema` instead. */ def alterTableDataSchema(db: String, table: String, newDataSchema: StructType): Unit + /** + * Alter the schema of a table identified by the provided database and table name. + * + * All partition columns must be preserved. + * + * @param db Database that table to alter schema for exists in + * @param table Name of table to alter schema for + * @param newSchema Updated data schema to be used for the table. + */ + def alterTableSchema(db: String, table: String, newSchema: StructType): Unit = + throw new UnsupportedOperationException( Review Comment: ok so you mean, just remove it. initially was thinking we can delegate to the other one, but its not possible unless we add another partition column argument, which will be messy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org