petern48 commented on PR #51253: URL: https://github.com/apache/spark/pull/51253#issuecomment-3046935196
@allisonwang-db I actually don't really see a good test we could write here? Do you? This function is actually a nested function (so more like a lambda) that is inside of a private function (`_assert_pandas_almost_equal`)... See [here](https://github.com/apache/spark/blob/a9b8e370893b271e2a8974c42feb31094b5bee8e/python/pyspark/testing/pandasutils.py#L128-L135). To me, it doesn't make sense to write a test at this level. Interestingly, this PR shouldn't change the behavior of the code at all since the variables `lval` and `rval` always happen to have the desired values of the intended arguments `val1` and `val2`. This change is more of a typo fix to protect against errors if someone were to change the code later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
