Github user kanzhang commented on the pull request:

    https://github.com/apache/spark/pull/6676#issuecomment-109461514
  
    For reviewers, for testing purposes, I factored out the building of 
ApplicationDescription and DriverDescription logic into separate methods in 
SparkDeploySchedulerBackend and ClientActor, respectively. No logic changes 
except adding a line to set auth secret in each and changed a line to filter 
out auth secret from sparkJavaOpts in each. I noticed that in 
SparkDeploySchedulerBackend, the original code uses Spark conf from two places, 
one is the passed-in sc.conf and the other is scheduler.sc.conf. For what I can 
tell, in all instances that SparkDeploySchedulerBackend is created, they points 
to the same conf. So I consolidate them into sc.conf in the refactored code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to