Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6660#discussion_r31858190
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -52,6 +53,45 @@ abstract class Expression extends TreeNode[Expression] {
def eval(input: Row = null): Any
/**
+ * Returns an [[GeneratedExpressionCode]], which contains Java source
code that
+ * can be used to generate the result of evaluating the expression on an
input row.
+ *
+ * @param ctx a [[CodeGenContext]]
+ * @return [[GeneratedExpressionCode]]
+ */
+ def gen(ctx: CodeGenContext): GeneratedExpressionCode = {
--- End diff --
I think that this can be `final`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]