peter-toth commented on code in PR #51432:
URL: https://github.com/apache/spark/pull/51432#discussion_r2202421414


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala:
##########
@@ -350,14 +350,19 @@ class QueryExecutionSuite extends SharedSparkSession {
   }
 
   test("SPARK-47764: Cleanup shuffle dependencies - RemoveShuffleFiles mode") {

Review Comment:
   No, your PR affects other `ShuffleCleanupMode`s too so the other 2 should 
work with both AQE enabled and disabled as well. All you need to do is to wrap 
those tests into an AQE on/off loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to