peter-toth commented on code in PR #51488:
URL: https://github.com/apache/spark/pull/51488#discussion_r2206928792
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala:
##########
@@ -162,11 +164,19 @@ class ThriftServerQueryTestSuite extends
SQLQueryTestSuite with SharedThriftServ
val sql = segments(i * 3 + 1).trim
val schema = segments(i * 3 + 2).trim
val originalOut = segments(i * 3 + 3)
- val output = if (schema != emptySchema && isNeedSort(sql)) {
- originalOut.split("\n").sorted.mkString("\n")
- } else {
- originalOut
- }
+ val output =
+ if (schema != emptySchema && isNeedSort(sql)) {
+ val splits = originalOut.split("\n")
+ if (splits.length > rowCounts(i)) {
+ // the result is multiline
+ val step = splits.length / rowCounts(i)
+ splits.sliding(step,
step).map(_.mkString("\n")).toSeq.sorted.mkString("\n")
Review Comment:
`.sliding(step, step)` -> `.grouped(step)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
