mridulm commented on code in PR #51503:
URL: https://github.com/apache/spark/pull/51503#discussion_r2209049429
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala:
##########
@@ -61,6 +61,18 @@ class DataSourceRDD(
private var currentIter: Option[Iterator[Object]] = None
private var currentIndex: Int = 0
+ private val partitionMetricCallback = if (columnarReads) {
+ new PartitionMetricCallback[ColumnarBatch](customMetrics)
+ } else {
+ new PartitionMetricCallback[InternalRow](customMetrics)
+ }
Review Comment:
nit: We dont really need the if/else here ... the bound gets ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
