MaxGekk commented on code in PR #51467: URL: https://github.com/apache/spark/pull/51467#discussion_r2212693010
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhyTypeOps.scala: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.types + +import org.apache.spark.sql.catalyst.expressions.MutableValue +import org.apache.spark.sql.types.{DataType, TimeType} + +// Base operations over Catalyst's types. +trait PhyTypeOps extends TypeOps { + // Gets the underlying physical type + def getPhysicalType: PhysicalDataType + + // Gets the Java class of the physical type + def getJavaClass: Class[_] + + // Gets a mutable container for the physical type + def getMutableValue: MutableValue +} + +object PhyTypeOps { + def supports(dt: DataType): Boolean = dt match { + case _: TimeType => true + case _ => false + } Review Comment: Ideal scenario would be to deal only with `TypeOps` objects but not with `DataType`. In that case, you can match them by a required interface, and use its methods like Create a `TypeOps` from a `DataType` -> propagate it everywhere -> at the end match it: ```scala def handle(ops: TypeOps) = ops match { case hashOps: HashTypeOps => ops.sha256(val) case _ => throw an error } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
