urosstan-db commented on code in PR #51519:
URL: https://github.com/apache/spark/pull/51519#discussion_r2213639068
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcSQLQueryBuilder.scala:
##########
@@ -208,7 +208,7 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options:
JDBCOptions) {
// If join has been pushed down, reuse join query as a subquery. Otherwise,
fallback to
// what is provided in options.
- private def tableOrQuery = joinQuery.getOrElse(options.tableOrQuery)
+ def tableOrQuery: String = joinQuery.getOrElse(options.tableOrQuery)
Review Comment:
If you need to access it from derived suites, but does not want to make it
overridable, you can use `protected final`
```suggestion
def tableOrQuery: String = joinQuery.getOrElse(options.tableOrQuery)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
