dongjoon-hyun commented on code in PR #215: URL: https://github.com/apache/spark-connect-swift/pull/215#discussion_r2213816832
########## Tests/SparkConnectTests/ConstraintTests.swift: ########## @@ -0,0 +1,85 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// + +import Foundation +import SparkConnect +import Testing + +/// A test suite for new syntaxes from SPARK-51207 (SPIP: Constraints in DSv2) +/// For now, only syntax test is here because Apache Spark 4.1 and the corresponding Apache Iceberg is not released yet. Review Comment: Thank you for review. Only `4.1.0-preveiw1` support this. ``` $ swift test --filter ConstraintTests ... Suite ConstraintTests started. Test primary_key() started. Test primary_key() passed after 0.118 seconds. Test foreign_key() started. Test foreign_key() passed after 0.059 seconds. Test unique() started. Test unique() passed after 0.088 seconds. Test check() started. Test check() passed after 0.087 seconds. Suite ConstraintTests passed after 0.354 seconds. Test run with 4 tests passed after 0.354 seconds. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
