uros-db commented on code in PR #51521:
URL: https://github.com/apache/spark/pull/51521#discussion_r2217357548
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala:
##########
@@ -421,6 +424,9 @@ abstract class HashExpression[E] extends Expression {
s"$result = $hasherClassName.hashInt($input.months, $microsecondsHash);"
}
+ private def legacyCollationAwareHashing: Boolean =
Review Comment:
Actually, I'm not sure whether we should do this. Caching a SQL config in
the current session is not good, because there's no mechanism to effectively
update/change the config value over time? i.e. this approach would always
revert to using the original default sql config value in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
