MaxGekk commented on code in PR #51573:
URL: https://github.com/apache/spark/pull/51573#discussion_r2221674777
##########
python/pyspark/sql/tests/test_functions.py:
##########
@@ -81,7 +81,9 @@ def test_function_parity(self):
missing_in_py = jvm_fn_set.difference(py_fn_set)
# Functions that we expect to be missing in python until they are
added to pyspark
- expected_missing_in_py = set()
+ expected_missing_in_py = set(
+ ["make_time"] # TODO(SPARK-52888): @uros-db is addressing this
separately.
Review Comment:
Let's don't assign tasks in the source code.
```suggestion
# TODO(SPARK-52888): Implement the make_time function in Python
["make_time"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
