mridulm commented on code in PR #51604:
URL: https://github.com/apache/spark/pull/51604#discussion_r2222823994
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -324,6 +324,10 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
val app = try {
load(appId)
} catch {
+ case _: NoSuchElementException if this.conf.get(ON_DEMAND_ENABLED) =>
+ val name = Utils.nameForAppAndAttempt(appId, attemptId)
+ loadFromFallbackLocation(appId, attemptId,
+ RollingEventLogFilesWriter.EVENT_LOG_DIR_NAME_PREFIX + name)
Review Comment:
We should not assume it will be `RollingEventLogFilesWriter`, users dont
need to be running with the default enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
