dongjoon-hyun commented on code in PR #51604:
URL: https://github.com/apache/spark/pull/51604#discussion_r2223789382
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -321,9 +321,13 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
override def getLastUpdatedTime(): Long = lastScanTime.get()
override def getAppUI(appId: String, attemptId: Option[String]):
Option[LoadedAppUI] = {
+ val logPath = RollingEventLogFilesWriter.EVENT_LOG_DIR_NAME_PREFIX +
+ Utils.nameForAppAndAttempt(appId, attemptId)
val app = try {
load(appId)
} catch {
+ case _: NoSuchElementException if
this.conf.get(EVENT_LOG_ROLLING_ON_DEMAND_LOAD_ENABLED) =>
Review Comment:
Could you elaborate on what we can break here, @thejdeep ?
> will this functionality not break for them since
EVENT_LOG_ROLLING_ON_DEMAND_LOAD_ENABLED is true by default ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
