dongjoon-hyun commented on code in PR #51604:
URL: https://github.com/apache/spark/pull/51604#discussion_r2223853069
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -364,6 +375,16 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
Some(loadedUI)
}
+ private def loadFromFallbackLocation(appId: String, attemptId:
Option[String], logPath: String)
+ : ApplicationInfoWrapper = {
+ val date = new Date(0)
+ val info = ApplicationAttemptInfo(attemptId, date, date, date, 0, "spark",
false, "unknown")
+ addListing(new ApplicationInfoWrapper(
+ ApplicationInfo(appId, appId, None, None, None, None, List.empty),
+ List(new AttemptInfoWrapper(info, logPath, 0, Some(1), None, None, None,
None))))
Review Comment:
Just questions to understand your use cases:
- How do you handle Spark Streaming Jobs with a single file event log ?
Still your job doesn't use rolling event logs?
- Are you assuming only Spark 2.x or 3.x jobs because Spark 4 jobs generates
rolling events by default since SPARK-45771?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
