Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6684#discussion_r31868258
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -79,9 +79,6 @@ abstract class StreamingLinearAlgorithm[
* @param data DStream containing labeled data
*/
def trainOn(data: DStream[LabeledPoint]): Unit = {
- if (model.isEmpty) {
--- End diff --
Hmm. It says here that, the initial weights are set to zero.
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala#L82
. And it seems that that was the intent previously as well and it was
incorrectly set as `Vectors.dense(numFeatures)`
Should this
(https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala#L62)
be changed to a non-empty model?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
