LuciferYang commented on code in PR #51775: URL: https://github.com/apache/spark/pull/51775#discussion_r2254591840
########## common/utils/src/main/java/org/apache/spark/internal/LogKeys.java: ########## @@ -0,0 +1,889 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.internal; + +/** + * Various keys used for mapped diagnostic contexts(MDC) in logging. All structured logging keys + * should be defined here for standardization. + */ +public enum LogKeys implements LogKey { Review Comment: Here, we employed a centralized Java enum to define all MDC keys. As far as I know, this approach results in the one-time initialization of all instances during class loading, thereby prolonging the class loading time and increasing memory usage. Previously, because Scala's case objects are lazily loaded, unused keys did not consume memory or require initialization time. Therefore, we may need to carry out some follow-up work later by splitting up this enum to mitigate the issues I've mentioned above. If I'm mistaken, please correct me. ########## common/utils/src/main/scala/org/apache/spark/internal/Logging.scala: ########## @@ -484,21 +477,21 @@ private[spark] object Logging { * Enable Structured logging framework. */ private[spark] def enableStructuredLogging(): Unit = { - structuredLoggingEnabled = true + SparkLoggerFactory.enableStructuredLogging() Review Comment: Are the modifications in these lines strongly related to the intent of this pull request (PR)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
