Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r31874085
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -66,6 +65,9 @@ private[spark] class CoarseMesosSchedulerBackend(
val extraCoresPerSlave = conf.getInt("spark.mesos.extra.cores", 0)
+ // Offer constraints
+ val slaveOfferConstraints =
parseConstraintString(sc.conf.get("spark.mesos.constraints", ""))
--- End diff --
Nit: Let's use the same exact style in both coarse and fine grain mode:
val slaveOfferConstraints =
parseConstraintString(sc.conf.get("spark.mesos.constraints", ""))
vs
private[mesos] val constraintsStr = sc.conf.get("spark.mesos.constraints",
"")
private[mesos] val offerConstraints = parseConstraintString(constraintsStr)
How about just use the top style?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
