Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6577#discussion_r31874213
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -80,6 +80,15 @@ abstract class JdbcDialect {
* @return The new JdbcType if there is an override for this DataType
*/
def getJDBCType(dt: DataType): Option[JdbcType] = None
+
+ /**
+ * Enclose column name
+ * @param colName The coulmn name
+ * @return Enclosed column name
+ */
+ def columnEnclosing(colName: String): String = {
--- End diff --
rename this "quoteIdentifier", and change the documentation to
```
Quotes the identifier. This is used to put quotes around the identifier in
case the column name is a reserved keyword, or in case it contains characters
that require quotes (e.g. space).
```
Remove the @param and @return.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
