LuciferYang commented on code in PR #51982:
URL: https://github.com/apache/spark/pull/51982#discussion_r2270522254
##########
.github/workflows/build_and_test.yml:
##########
@@ -378,7 +387,24 @@ jobs:
MODULES_TO_TEST=${MODULES_TO_TEST//streaming-kinesis-asl, /}
fi
export SERIAL_SBT_TESTS=1
- ./dev/run-tests --parallelism 1 --modules "$MODULES_TO_TEST"
--included-tags "$INCLUDED_TAGS" --excluded-tags "$EXCLUDED_TAGS"
+
+ if [[ "$TEST_SPLIT" != "" && "$INCLUDED_TAGS" == *"SlowSQLTest"* ]];
then
+ # Split SlowSQLTest classes alphabetically using SBT testOnly
+ SLOW_SQL_CLASSES=$(find . -name "*.scala" -exec grep -l
"@SlowSQLTest" {} \; | sed 's|.*/||' | sed 's|\.scala||' | sort)
+ TOTAL_CLASSES=$(echo "$SLOW_SQL_CLASSES" | wc -l)
+ HALF=$((TOTAL_CLASSES / 2))
+
+ if [[ "$TEST_SPLIT" == "part1" ]]; then
+ TEST_CLASSES=$(echo "$SLOW_SQL_CLASSES" | head -n $HALF | paste
-sd ',' -)
Review Comment:
Looking solely at the code, there are two issues here:
1. The result of `TEST_CLASSES` is
`AcceptsLatestSeenOffsetSuite,AdaptiveQueryExecSuite,AggregateHashMapSuite,AllExecutionsPageSuite,...`,
but in reality, they should be `*AcceptsLatestSeenOffsetSuite
*AdaptiveQueryExecSuite *AggregateHashMapSuite,*AllExecutionsPageSuite,...`，so
none of the tests are being executed at all now.
- https://github.com/ericm-db/spark/actions/runs/16895995712/job/47867693939
3. Some test case names are incorrect. For example,
`AggregateHashMapSuite.scala` contains three `SlowSQLTest`s:
`SingleLevelAggregateHashMapSuite`, `TwoLevelAggregateHashMapSuite`, and
`TwoLevelAggregateHashMapWithVectorizedMapSuite`. Even if
`*AggregateHashMapSuite` is executed, it will not trigger valid tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
