Kimahriman commented on code in PR #48488:
URL: https://github.com/apache/spark/pull/48488#discussion_r2274903463
##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -1465,6 +1466,16 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
sc.stop()
}
+ test("SPARK-49984: Don't duplicate default Java options to extra Java
options") {
+ val conf = new SparkConf().setAppName("test").setMaster("local")
+ conf.set(SparkLauncher.DRIVER_DEFAULT_JAVA_OPTIONS, "-Dfoo=bar")
+ conf.set(SparkLauncher.EXECUTOR_DEFAULT_JAVA_OPTIONS, "-Dfoo=bar")
+ sc = new SparkContext(conf)
+
assert(!sc.conf.get(SparkLauncher.DRIVER_EXTRA_JAVA_OPTIONS).contains("-Dfoo=bar"))
+
assert(!sc.conf.get(SparkLauncher.EXECUTOR_EXTRA_JAVA_OPTIONS).contains("-Dfoo=bar"))
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
