dongjoon-hyun commented on code in PR #52027:
URL: https://github.com/apache/spark/pull/52027#discussion_r2279892676


##########
core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala:
##########
@@ -52,6 +52,46 @@ class SparkHadoopUtilSuite extends SparkFunSuite {
     assertConfigValue(hadoopConf, "fs.s3a.downgrade.syncable.exceptions", 
"false")
   }
 
+  /**
+   * Verify that the GCS user agent is set correctly when no custom suffix is 
provided.
+   */
+  test("GCS user agent should be set when not provided by user") {

Review Comment:
   Although this is not a bug fix, I'd recommend you to have a habit to use a 
test name prefix for the other community members, @shrutisinghania . The style 
is documented in the following link. I know that it's a little annoying to the 
contributors, but the style is very helpful during reviewing process and for 
the future problem analysis for the rest of community members always because we 
are able to use them as a test selector.
   
   - https://spark.apache.org/contributing.html
   
   ```scala
   test("GCS user agent should be set when not provided by user") {
   test("SPARK-52336: GCS user agent should be set when not provided by user") {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to