JkSelf commented on code in PR #52039:
URL: https://github.com/apache/spark/pull/52039#discussion_r2283983312
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala:
##########
@@ -195,6 +195,10 @@ object SQLExecution extends Logging {
}
}
}
+
+ sparkSession.sparkContext.cancelJobsWithTag(
+ executionIdJobTag(sparkSession, executionId))
Review Comment:
> We should only do this if this is the root execution
It seems that `EXECUTION_ROOT_ID_KEY `is already set to executionId
[here](https://github.com/JkSelf/spark/blob/f44a0e861534a629bbd68973aeb43aceebe4cd16/sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala#L86-L89),
so there's no need to add this check, right?
>BTW does it work for AQE?
Yes. I re-ran the test with AQE enabled, and it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
