sandip-db commented on code in PR #52093:
URL: https://github.com/apache/spark/pull/52093#discussion_r2292526883
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/StaxXmlParser.scala:
##########
@@ -1035,18 +1035,31 @@ object StaxXmlParser {
}
def convertStream[T](inputStream: () => InputStream, options: XmlOptions)(
- convert: StaxXMLRecordReader => T): Iterator[T] = new Iterator[T] {
- private val reader = StaxXMLRecordReader(inputStream, options)
+ convert: StaxXMLRecordReader => T): Iterator[T] =
+ try {
+ new Iterator[T] {
+ private val reader = StaxXMLRecordReader(inputStream, options)
- override def hasNext: Boolean = reader.hasMoreRecord
Review Comment:
Instead of catching the same errors in multiple places, can you defer the
`reader` initialization?
override def hasNext: Boolean = {
if (reader == null) {
reader = StaxXMLRecordReader(inputStream, options)
}
reader.hasMoreRecord
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
