cloud-fan commented on code in PR #47856:
URL: https://github.com/apache/spark/pull/47856#discussion_r2297038532
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArray.scala:
##########
@@ -138,6 +142,7 @@ private[sql] class ExternalAppendOnlyUnsafeRowArray(
initialSize,
pageSizeBytes,
numRowsSpillThreshold,
+ maxSizeSpillThreshold,
Review Comment:
looking at this `def add` method, it trigger spilling only if the num rows
exceeds `numRowsInMemoryBufferThreshold`. IIUC we are not using memory-based
threshold here, as we keep appending data to a memory buffer based on the num
rows threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
