dongjoon-hyun commented on code in PR #51396: URL: https://github.com/apache/spark/pull/51396#discussion_r2299605003
########## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala: ########## @@ -514,6 +525,24 @@ private[spark] object Config extends Logging { .booleanConf .createWithDefault(true) + val KUBERNETES_EXECUTOR_LISTER_POLLING_INTERVAL = + ConfigBuilder("spark.kubernetes.executor.listerPollingInterval") + .doc("Interval between polls against the Kubernetes informer cache to inspect the " + + "state of executors.") + .version("4.1.0") + .timeConf(TimeUnit.MILLISECONDS) + .checkValue(interval => interval > 0, s"informer lister polling interval must be a" + + " positive time value.") + .createWithDefaultString("30s") + + val KUBERNETES_EXECUTOR_INFORMER_RESYNC_INTERVAL = + ConfigBuilder("spark.kubernetes.executor.informerResyncInterval") + .doc("Interval between informer cache resync") + .version("4.1.0") + .timeConf(TimeUnit.MILLISECONDS) + .checkValue(interval => interval >= 0, s"informer resync interval must not be a negative" + + s" time value.") Review Comment: ditto. `s" time ` -> `" time ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org