dtenedor commented on code in PR #51298:
URL: https://github.com/apache/spark/pull/51298#discussion_r2302272241
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -3193,6 +3193,66 @@ class PlanGenerationTestSuite
binary.select(fn.hll_union_agg("bytes"))
}
+ test("theta_sketch_agg with column lgNomEntries") {
Review Comment:
To be honest, this part adds a lot of JSON and .proto.bin file contents to
this PR without a lot of test coverage benefit. I'd remove this part entirely
and focus on golden file test coverage with .sql/.sql.out files, and regular
unit test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
