mridulm commented on code in PR #52084:
URL: https://github.com/apache/spark/pull/52084#discussion_r2302827967


##########
core/src/main/scala/org/apache/spark/SparkConf.scala:
##########
@@ -345,7 +346,7 @@ class SparkConf(loadDefaults: Boolean)
 
   /** Set a name for your application. Shown in the Spark web UI. */
   def setAppName(name: String): SparkConf = {
-    set("spark.app.name", name)
+    set("spark.app.name", StringEscapeUtils.escapeHtml4(name))

Review Comment:
   Agree with @dongjoon-hyun.
   Instead, it would be better to simply escape this in Spark UI, so that what 
gets returned works for html.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to