cloud-fan commented on code in PR #52139:
URL: https://github.com/apache/spark/pull/52139#discussion_r2303004261
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -100,8 +100,12 @@ private[spark] class UninterruptibleThread(
* @return true when there is no concurrent [[runUninterruptibly()]] call
([[uninterruptible]]
* is true) and no concurrent [[interrupt()]] call, otherwise false
*/
- def isInterruptible: Boolean = synchronized {
- shouldInterruptThread = uninterruptible
+ def isInterruptible(t: Thread): Boolean = synchronized {
Review Comment:
I think in scala we can just do `UninterruptibleThread.this`, then we don't
need to take a new parameter in this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
