karuppayya commented on code in PR #51458:
URL: https://github.com/apache/spark/pull/51458#discussion_r2306280611
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3567,12 +3567,27 @@ object SQLConf {
val SHUFFLE_DEPENDENCY_FILE_CLEANUP_ENABLED =
buildConf("spark.sql.shuffleDependency.fileCleanup.enabled")
- .doc("When enabled, shuffle files will be cleaned up at the end of Spark
Connect " +
- "SQL executions.")
+ .doc("(Deprecated since Spark 4.1, please set" +
+ " 'spark.sql.connect.shuffleDependency.fileCleanup.enabled'.)")
.version("4.0.0")
.booleanConf
.createWithDefault(Utils.isTesting)
+ val CLASSIC_SHUFFLE_DEPENDENCY_FILE_CLEANUP_ENABLED =
+ buildConf("spark.sql.classic.shuffleDependency.fileCleanup.enabled")
Review Comment:
+1 , thanks for bringing this up
I will have this handled in a follow up PR soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
