cloud-fan commented on code in PR #52157: URL: https://github.com/apache/spark/pull/52157#discussion_r2307002808
########## sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala: ########## @@ -150,7 +150,7 @@ class QueryExecution( // with the rest of processing of the root plan being just outputting command results, // for eagerly executed commands we mark this place as beginning of execution. tracker.setReadyForExecution() - val qe = sparkSession.sessionState.executePlan(p, mode) + val qe = sparkSession.sessionState.executePlan(p, mode, shuffleCleanupMode) Review Comment: instead of calling `executePlan`, can we construct `QueryExecution` instance directly? I feel this `executePlan` method is a bit useless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org