anishshri-db commented on code in PR #52148: URL: https://github.com/apache/spark/pull/52148#discussion_r2308804749
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSource.scala: ########## @@ -576,29 +577,46 @@ object StateSourceOptions extends DataSourceOptions { batchId.get } - val operatorStateUniqueIds = getOperatorStateUniqueIds( + val endBatchId = if (readChangeFeedOptions.isDefined) { + readChangeFeedOptions.get.changeEndBatchId + } else { + batchId.get + } + + val startOperatorStateUniqueIds = getOperatorStateUniqueIds( sparkSession, startBatchId, operatorId, resolvedCpLocation) - if (operatorStateUniqueIds.isDefined) { + val endOperatorStateUniqueIds = if (startBatchId == endBatchId) { + startOperatorStateUniqueIds + } else { + getOperatorStateUniqueIds( + sparkSession, + endBatchId, + operatorId, + resolvedCpLocation) + } + + if (startOperatorStateUniqueIds.isDefined != endOperatorStateUniqueIds.isDefined) { + throw StateDataSourceErrors.internalError( Review Comment: Just to confirm - this is backed by an error class correct ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org