dongjoon-hyun commented on PR #52027: URL: https://github.com/apache/spark/pull/52027#issuecomment-3237893744
@shrutisinghania . I can give you some advice to move forward. For example, 1. Focus on advertising this PR's exact contribution precisely without brining irrelevant claims (or benefits). In this case, this PR is totally irrelevant with distinguishing individual Spark jobs. If you claim it in the PR title or description, that could be a blocker for you to move forward this PR. 2. Try to remove any regression. For example, it would be more easier to move forward if you don't inject any configuration when `fs.gs.application.name.suffix` doesn't exist. When `fs.gs.application.name.suffix` exists, we can assume the it's GCS users, so you can persuade the community that this is a reasonable extension of information for GCS users. In addition, you can claim that there is no regression for non-GCS users because you code will not touch anything. 3. Lastly, when you extend the existing `fs.gs.application.name.suffix`, you may want to double-check the existing value of configuration has those patterns or not at least. From the Apache Spark community perspective, we need to protect all Spark users (including non-GCS users and the existing GCS users) from this PR. So, please consider in conservative ways like the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
