cloud-fan commented on code in PR #52190:
URL: https://github.com/apache/spark/pull/52190#discussion_r2315149038
##########
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java:
##########
@@ -90,9 +90,9 @@ final class ShuffleExternalSorter extends MemoryConsumer
implements ShuffleCheck
private final int numElementsForSpillThreshold;
/**
- * Force this sorter to spill when the size in memory is beyond this
threshold.
+ * Force this sorter to spill when the in memory size in bytes is beyond
this threshold.
*/
- private final long recordsSizeForSpillThreshold;
+ private final long sizeInBytesForSpillThreshold ;
Review Comment:
```suggestion
private final long sizeInBytesForSpillThreshold;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
