zhengruifeng commented on code in PR #52197:
URL: https://github.com/apache/spark/pull/52197#discussion_r2315292048
##########
python/pyspark/ml/connect/classification.py:
##########
@@ -381,7 +381,7 @@ def _save_core_model(self, path: str) -> None:
def _load_core_model(self, path: str) -> None:
import torch
- lor_torch_model = torch.load(path)
+ lor_torch_model = torch.load(path, weights_only=False)
Review Comment:
torch>=2.6.0 fails with
```
Traceback (most recent call last):
File
"/__w/spark/spark/python/pyspark/ml/tests/connect/test_legacy_mode_classification.py",
line 185, in test_save_load
lor_torch_model = torch.load(
^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/torch/serialization.py",
line 1529, in load
raise pickle.UnpicklingError(_get_wo_message(str(e))) from None
_pickle.UnpicklingError: Weights only load failed. This file can still be
loaded, to do so you have two options, do those steps only if you trust the
source of the checkpoint.
(1) In PyTorch 2.6, we changed the default value of the `weights_only`
argument in `torch.load` from `False` to `True`. Re-running `torch.load` with
`weights_only` set to `False` will likely succeed, but it can result in
arbitrary code execution. Do it only if you got the file from a trusted source.
(2) Alternatively, to load with `weights_only=True` please check the
recommended steps in the following error message.
WeightsUnpickler error: Unsupported global: GLOBAL
torch.nn.modules.container.Sequential was not an allowed global by default.
Please use
`torch.serialization.add_safe_globals([torch.nn.modules.container.Sequential])`
or the
`torch.serialization.safe_globals([torch.nn.modules.container.Sequential])`
context manager to allowlist this global if you trust this class/function.
Check the documentation of torch.load to learn more about types accepted by
default with weights_only
https://pytorch.org/docs/stable/generated/torch.load.html.
```
to resolve this, add `weights_only=False`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
