shujingyang-db commented on code in PR #52153: URL: https://github.com/apache/spark/pull/52153#discussion_r2317810412
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DirectShufflePartitionID.scala: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, ExprCode, FalseLiteral} +import org.apache.spark.sql.catalyst.expressions.codegen.Block._ +import org.apache.spark.sql.types.{AbstractDataType, DataType, LongType} + +/** + * Expression that takes a partition ID value and passes it through directly for use in + * shuffle partitioning. This is used with RepartitionByExpression to allow users to + * directly specify target partition IDs. + * + * The child expression must evaluate to an integral type and must not be null. + * The resulting partition ID must be in the range [0, numPartitions). + */ +case class DirectShufflePartitionID(child: Expression) + extends UnaryExpression + with ExpectsInputTypes { + + override def dataType: DataType = child.dataType + + override def inputTypes: Seq[AbstractDataType] = LongType :: Nil + + override def nullable: Boolean = false + + override val prettyName: String = "direct_shuffle_partition_id" + + override def eval(input: InternalRow): Any = { + val result = child.eval(input) + if (result == null) { + throw new IllegalArgumentException( Review Comment: Update: removing this as we mark DirectShufflePartitionID as Unevaluable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
